fixes #243 Credentials exposed #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx! |
bmwiedemann
added a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jan 6, 2020
https://build.opensuse.org/request/show/761142 by user dimstar_suse - dropped Python 2 support, not supported by the package - update to version 5.0.0: * Fix for credentials exposure (jasonrbriggs/stomp.py#244) * Check for ``STOMP_SKIP_HOSTNAME_SCAN`` environment variable before extending ``LOCALHOST_NAMES`` * Remove python2 backwards compatibility * Update dockerfile for better local testing * Fix docker and travis setup, so there are consistent builds both locally and via CI * Drop deprecated start/stop methods from connection (issue jasonrbriggs/stomp.py#257) * Fix for missing return in get_ssl (jasonrbriggs/stomp.py#258) * Clear heartbeat event after heartbeat loop ends (jasonrbriggs/stomp.py#260) * Update listener to move receive/message_received/
|
@jasonrbriggs can I ask that this fix is merged into a 4.x tag, please as one of our legacy apps still uses Python 2.7. |
|
@lewis-spears Released version 4.1.24 to resolve.., |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #243 by adding utils.clean_lines to mask passcode in the transport log (at debug level) and by using the existing utils.clean_headers to do the same in PrintingListener