fix: Either.bind method doesn't support type hint as well
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fResult
force-pushed
the
fix-bind-method-type-signature-doesnt-correctly-give-type-hint
branch
from
6b0c008 to
22be46e
Compare
maestro-1
reviewed
Apr 29, 2024
| def bind( | ||
| self: 'Either[M, S]', kleisli_function: Callable[[S], 'Either[M, T]'] | ||
| ) -> 'Either[M, T]': | ||
| def bind[Err, Val]( |
There was a problem hiding this comment.
Unless you defined Err and Val in a previous PR, this will likely break the typing. S and T are referenced via TypeVar. Err and Val are not.
Also, you need to consider backward compatibility, this way of defining generics isn't supported earlier than python 3.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Either.bindfunction doesn't support type hint as well #34.If there is anything improper, please don't hesitate to give me suggestions. 😉