Fix errors with site references #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change site function, especially the site name reference, can break users that only have Solar-Only Tesla inverters. Make the two change_site functions consistent and fix other issues where site_name is not provided by the Tesla API.
|
Thanks @Nexarian ! Good fix to expand use for Solar-Only owners. I've merged and tested. I'll include this in the upcoming release (v0.11.2). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Tesla user here, I have only Tesla solar inverters, and I was unable to access them with pypowerwall unless I applied this fix. Pypowerwall would crash when trying to find the site_name. The broken line was
self.siteid = sites[self.siteindex].get('energy_site_id')inpypowerwall_fleetapi.pyOtherwise, make the change_site functions consistent and less error-prone! The change site function, especially the site name reference, can break users that only have Solar-Only Tesla inverters. Make the two change_site functions consistent and fix other issues where site_name is not provided by the Tesla API.