Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to specify name of existing connection string for SqlFeatureToggle #97

Merged
merged 1 commit into from
Jul 8, 2015
Merged

Allow user to specify name of existing connection string for SqlFeatureToggle #97

merged 1 commit into from
Jul 8, 2015

Conversation

craig-wagner
Copy link
Contributor

The connection string can now be specified three ways...

Entirely in <appSettings> (existing functionality):

<appSettings>
    <add key="FeatureToggle.MyFeatureToggle.ConnectionString" value="Data Source=..." />
</appSettings>

Entirely in <connectionStrings> (existing functionality as of 3.1):

<connectionStrings>    
    <add name="FeatureToggle.MySqlServerToggleFalse" connectionString="Data Source=..." />    
</connectionStrings>

By specifying name of existing connection string in <connectionStrings> in the <appSettings> (new functionality):

<connectionStrings>
    <add name="primary" connectionString="Data Source=..." />
</connectionStrings>

<appSettings>
    <add key="FeatureToggle.MyFeatureToggle.ConnectionStringName" value="primary" />
</appSettings>

@craig-wagner
Allow user to configure connection string for a SqlFeatureToggle by s…
3c1a39c 
…pecifying the name of an existing connection string

User can now specify .ConnectionString (full connection string) or
.ConnectionStringName (name of connection string from
<connectionStrings> section) in the <appSettings>.
@craig-wagner craig-wagner mentioned this pull request Jul 4, 2015
Closed
jason-roberts added a commit that referenced this pull request Jul 8, 2015
@jason-roberts
Merge pull request #97 from craig-wagner/master
02a13b3 
Allow user to specify name of existing connection string for SqlFeatureToggle
@jason-roberts jason-roberts merged commit 02a13b3 into jason-roberts:master Jul 8, 2015
@jason-roberts
Copy link
Owner

Thanks @craig-wagner :)

@jason-roberts
Copy link
Owner

ps. @craig-wagner congrats on your first open source contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@craig-wagner @jason-roberts