Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github action #30

Merged
merged 10 commits into from
Feb 15, 2024
Merged

Add github action #30

merged 10 commits into from
Feb 15, 2024

Conversation

jason-neal
Copy link
Owner

No description provided.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: This pull request introduces a GitHub Actions workflow aimed at automating the process of installing Python dependencies, running tests, and linting across multiple Python versions. It is designed to trigger on push and pull request events to the master branch, ensuring code quality and consistency with every change.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.

General suggestions:

  • Consider revising the conditional checks for installing requirements to ensure essential dependencies are always installed, enhancing the reliability of the workflow.
  • It might be beneficial to specify a minimum acceptable coverage percentage in the testing step to maintain or improve code quality standards over time.
  • Review the integration setup for the coverage and code quality reporting tools (Coveralls, Code Climate, and Codacy) to ensure they are correctly configured and provide unique insights into the codebase.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@jason-neal jason-neal merged commit b39f48a into master Feb 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant