Merge pull request #84 from ybian/null_stack

Fix #83 - default console reporter hangs sometimes
jasmine · Sep 28, 2016 · 1b60f4a · 1b60f4a
2 parents df43829 + 6de5013
commit 1b60f4a
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 0 deletions.
diff --git a/lib/reporters/console_reporter.js b/lib/reporters/console_reporter.js
@@ -169,6 +169,10 @@ function ConsoleReporter() {
   }
 
   function defaultStackFilter(stack) {
+    if (!stack) {
+      return '';
+    }
+
     var filteredStack = stack.split('\n').filter(function(stackLine) {
       return stackLine.indexOf(jasmineCorePath) === -1;
     }).join('\n');

diff --git a/spec/reporters/console_reporter_spec.js b/spec/reporters/console_reporter_spec.js
@@ -281,6 +281,36 @@ describe("ConsoleReporter", function() {
     expect(this.out.getOutput()).not.toMatch(jasmineCorePath);
   });
 
+  it("reports a summary when done in case that stack is somehow undefined", function() {
+    var reporter = new ConsoleReporter({
+      print: this.out.print,
+      jasmineCorePath: jasmineCorePath
+    });
+
+    reporter.jasmineStarted();
+    reporter.specDone({status: "passed"});
+    reporter.specDone({
+      status: "failed",
+      description: "with a failing spec",
+      fullName: "A suite with a failing spec",
+      failedExpectations: [
+        {
+          passed: false,
+          message: "Expected true to be false.",
+          expected: false,
+          actual: true,
+          stack: undefined
+        }
+      ]
+    });
+
+    this.out.clear();
+
+    reporter.jasmineDone();
+
+    expect(this.out.getOutput()).toMatch(/true to be false/);
+  });
+
   it("reports a summary when done that includes custom filtered stack traces for a failing suite", function() {
     var stackLine = 'custom line of stack';
     var customStackFilter = function(stack) {