-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow leading logical operators #5279
base: main
Are you sure you want to change the base?
Allow leading logical operators #5279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This old PR looks nice too. I recently ran into this issue when editing the CoffeeScript source, and wanting to write:
if (really_long_line
or another_long_line) and ...
(because the or
didn't fit on the first line). I think it'd be nice for this to be equivalent to
if (really_long_line or
another_long_line) and ...
which this PR does.
This one is fine too, it just needs a rebase. |
I like this proposal, let me know if there is anything I can do to help. |
Hi guys, sorry I've been MIA on Coffeescript stuff, mostly been focusing on other things I merged Also the details of this PR are a bit fuzzy but I'd tend to trust my past self 😜 |
Run I put a note on the other version of this, is there a way to handle this without introducing a new rewriter pass? It feels like something that should be doable within the lexer. |
@GeoffreyBooth re-opening against
master
See original PR: #5068