Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3906: safe missing end token error #4586

Closed

Conversation

helixbass
Copy link
Collaborator

Fixes #3906

This fixes the TypeError thrown by the compiler when trying to compile the examples from #3906. All of the examples from that issue except @GeoffreyBooth's should really successfully compile though - I fixed that as well, but figure that the compiler-throwing-an-error part should be merged into master while the fix-wonky-indentation-behavior part should be merged into 2? So I'll open a second pull request against 2 that makes those examples compile successfully

@GeoffreyBooth
Copy link
Collaborator

I think at this point, the only fixes that we should be merging into master are fixes for recent regressions. #3906 has been an open issue for over two years, so it shouldn’t be affecting anyone at the moment. I think it can stay unresolved in 1.x and only get fixed in 2. I’m much more concerned that fixing it could create another unintended regression like #4568 (which we should fix in 1.x, if we can find a way to do so without allowing syntax that isn’t possible in 2; @helixbass you’re probably the best one to tackle that if you don’t mind).

@lydell or @jashkenas, do you agree?

@lydell
Copy link
Collaborator

lydell commented Jun 26, 2017

Yes, I agree. 👍

@GeoffreyBooth
Copy link
Collaborator

@helixbass Can you please retarget this at 2 and/or combine it with #4587?

@helixbass
Copy link
Collaborator Author

@GeoffreyBooth sure, merged this into #4587. And ya I can take a look at #4568

@helixbass helixbass closed this Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lexer: Chaining: Variable indents throw TypeError during compilation
3 participants