Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2] Destructuring object spreads #4493

Merged
merged 90 commits into from
Jun 30, 2017
Merged

[CS2] Destructuring object spreads #4493

Show file tree
Hide file tree
Changes from 39 commits
Commits
Show all changes
90 commits
Select commit Hold shift + click to select a range
17511d4
Don’t confuse the syntax highlighter
GeoffreyBooth Feb 5, 2017
590cd3f
Comment Assign::compilePatternMatch a bit
lydell Feb 5, 2017
f0ebb0a
Merge branch 'destructuring-comments' of github.com:lydell/coffee-scr…
GeoffreyBooth Feb 6, 2017
1b2d847
Assignment expressions in conditionals are a bad practice
GeoffreyBooth Feb 9, 2017
d3278b2
Merge branch '2' into destructuring
GeoffreyBooth Mar 22, 2017
11d6c59
Rename `wrapInBraces` to `wrapInParentheses`, to set the stage for fu…
GeoffreyBooth Mar 24, 2017
5224e76
Correct comment
GeoffreyBooth Mar 24, 2017
d8cca79
object destructuring
Mar 26, 2017
49001d7
Allow custom position of the rest element.
Mar 27, 2017
59959a6
Output simple array destructuring assignments to ES2015
Mar 30, 2017
b9f8f5d
Output simple object destructured assignments to ES2015
Mar 30, 2017
066071f
Compile shorthand object properties to ES2015 shorthand properties
Mar 30, 2017
429ab12
Don’t confuse the syntax highlighter
GeoffreyBooth Feb 5, 2017
d60053a
Comment Assign::compilePatternMatch a bit
lydell Feb 5, 2017
9ea695a
Assignment expressions in conditionals are a bad practice
GeoffreyBooth Feb 9, 2017
c4761cb
Rename `wrapInBraces` to `wrapInParentheses`, to set the stage for fu…
GeoffreyBooth Mar 24, 2017
840b4a4
object destructuring
Mar 26, 2017
c26164e
Allow custom position of the rest element.
Mar 27, 2017
f36ae29
rest element in object destructuring
Apr 1, 2017
c8b63eb
rest element in object destructuring
Apr 2, 2017
9a17905
fix string interpolation
Apr 2, 2017
b7bb4c9
merge
Apr 2, 2017
25b1ab6
merging
Apr 2, 2017
8984f2e
fixing splats in object literal
Apr 3, 2017
d65b247
Rest element in parameter destructuring
Apr 4, 2017
35e9646
merging with CS2
Apr 9, 2017
2326a5b
merging with CS2
Apr 9, 2017
d9c84cd
merged with CS2
Apr 9, 2017
55e0b62
Add support for the object spread initializer. https://github.com/tc3…
Apr 13, 2017
7045a35
Merge branch '2' of github.com:jashkenas/coffeescript into destructur…
GeoffreyBooth May 7, 2017
12931fe
Fix misspellings, trailing whitespace, other minor details
GeoffreyBooth May 7, 2017
aed10ea
merging with beta2
May 30, 2017
fc7a8fa
merging with beta2
May 30, 2017
cc58cec
refactor object spread properties
May 30, 2017
8417d0f
refactor object spread properties
May 30, 2017
a5f2708
small fix
May 30, 2017
d25576a
- Fixed object spread function parameters.
Jun 4, 2017
c544a37
Fixed typos
Jun 4, 2017
2e72646
Remove unused code
Jun 4, 2017
4fcaec7
Removed dots (e.g. splat) on the left side from the grammar
Jun 6, 2017
d59be16
Initial release for deep spread properties, e.g. obj2 = {obj.b..., a:…
Jun 7, 2017
286d4c7
1. Object literal spread properties
Jun 11, 2017
c20a4d3
Merging with 2.0
Jun 11, 2017
06606c3
Merged with 2.0
Jun 11, 2017
37787ae
Cleanup
Jun 12, 2017
7d8fceb
Some more cleanup.
Jun 12, 2017
9dfc148
Fixed error with freeVariable and object destructuring.
Jun 12, 2017
4815aa4
Fixed errors with object spread properties.
Jun 12, 2017
085e0cb
Improvements, fixed errors.
Jun 12, 2017
e170eee
Minor improvement.
Jun 12, 2017
4bc224f
Minor improvements.
Jun 12, 2017
c4f112e
Typo.
Jun 12, 2017
41fbbf0
Remove unnecessary whitespace.
Jun 13, 2017
d7a3945
Remove unnecessary whitespace.
Jun 13, 2017
8ccc4d4
Changed few "assertErrorFormat" tests since parentheses are now allow…
Jun 14, 2017
a24ba42
Merged with 2
Jun 15, 2017
a2eb546
Whitespace cleanup
GeoffreyBooth Jun 15, 2017
9dda2ba
Comments cleanup
GeoffreyBooth Jun 15, 2017
f864463
fix destructured obj param declarations
helixbass Jun 16, 2017
a339e16
refine fix; add test
helixbass Jun 16, 2017
deda22e
Refactor function args ({a, b...})
Jun 16, 2017
44337dc
Additional tests for object destructuring in function argument.
Jun 16, 2017
b68d23a
Minor improvement for object destructuring variable declaration.
Jun 16, 2017
83983c4
refactor function args ({a, b...}) and ({a, b...} = {}); Obj And Para…
Jun 17, 2017
7e536e3
fix comment
Jun 17, 2017
b2411c7
Fix object destructuring variable declaration.
Jun 17, 2017
515d981
more tests with default values
Jun 17, 2017
2af867a
fix typo
Jun 18, 2017
3a90db9
Fixed default values in object destructuring.
Jun 20, 2017
2dd0439
small fix
Jun 20, 2017
ad29a18
Merged in 2
Jun 22, 2017
e10f8c4
Babel’s tests for object rest spread
GeoffreyBooth Jun 26, 2017
ab23c7f
Style: spaces after colons in object declarations
GeoffreyBooth Jun 26, 2017
f718fa7
Cleanup comments
GeoffreyBooth Jun 26, 2017
0ef94a1
Simplify Babel tests
GeoffreyBooth Jun 26, 2017
5163634
Fix comments
GeoffreyBooth Jun 26, 2017
ec5d2c0
Fix destructuring with splats in multiple objects
connec Jun 29, 2017
4752477
Add test for default values in detsructuring assignment with splats
connec Jun 29, 2017
2dd0709
Handle default values when assigning to object splats
connec Jun 29, 2017
4c8af9c
Rewrite traverseRest to fix handling of dynamic keys
connec Jun 29, 2017
dab4a12
Fix double parens around destructuring with splats
connec Jun 29, 2017
7d7f4e6
Update compileObjectDestruct comments
connec Jun 29, 2017
620846e
Improve formatting of top-level destructures with splats and tidy parens
connec Jun 29, 2017
2dbc8b8
Added a bigger destructuring-with-defaults test and fixed a bug
connec Jun 30, 2017
8ae0240
Refactor destructuring grammar to allow additional forms
connec Jun 30, 2017
e4f9c20
Add a missing case to ObjSpreadExpr
connec Jun 30, 2017
b333a92
These tests shouldn’t run in the browser
GeoffreyBooth Jun 30, 2017
6775b62
Fix test.html
GeoffreyBooth Jun 30, 2017
d189caf
Merge branch '2' of github.com:jashkenas/coffeescript into destructur…
GeoffreyBooth Jun 30, 2017
1cd1463
Merge branch '2' of github.com:jashkenas/coffeescript into destructur…
GeoffreyBooth Jun 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ test/*.js
parser.output
/node_modules
npm-debug.log*
yarn.lock
8 changes: 8 additions & 0 deletions lib/coffeescript/grammar.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading