Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodes: Remove polyfill for object rest/spread #4876

Closed
GeoffreyBooth opened this issue Feb 2, 2018 · 0 comments
Closed

Nodes: Remove polyfill for object rest/spread #4876

GeoffreyBooth opened this issue Feb 2, 2018 · 0 comments
Labels
change

Comments

@GeoffreyBooth
Copy link
Collaborator

The object rest/spread syntax, e.g. { x, y, ...z }, has reached Stage 4 (a.k.a. it’s been approved as part of ES2018). When this feature was implemented in #4493, the syntax was only Stage 3, and so a polyfill was added as per our policy. But now that the syntax is finalized, and supported by Node 8.6+, we can remove the polyfill.
@zdenko zdenko mentioned this issue Feb 4, 2018
Merged
GeoffreyBooth pushed a commit that referenced this issue Apr 23, 2018
@zdenko @GeoffreyBooth
Fix #4876: remove polyfill for object rest/spread (#4884)
871079b 
* object rest/spread

* merge branch 'master' into 'object_rest_spread'

* explore

* Revert "merge branch 'master' into 'object_rest_spread'"

This reverts commit eeeffef.

* Revert "explore"

This reverts commit d21cd72.

* split tests

* improvements

* unassignable rest property

* cleanup

* formatting, cleanup

* handle non-final object-destructured splat

* merge with @helixbass's branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GeoffreyBooth