Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CS2] super.x.y throws a compiler error #4591

Closed
helixbass opened this issue Jun 26, 2017 · 1 comment
Closed

[CS2] super.x.y throws a compiler error #4591

helixbass opened this issue Jun 26, 2017 · 1 comment
Labels
fixed
Milestone
2.0.0

Comments

@helixbass
Copy link
Collaborator

Starting to go through nodes.coffee for comprehension, noticed that in the SimpleAssignable grammar rules, Value Accessor assumes that it can call .add() on the Value, but Super (which is a Value in the grammar) doesn't have an .add() method. So things like super.x.y and super['x'].y throw compiler errors when trying to call the missing .add() method
helixbass added a commit to helixbass/copheescript that referenced this issue Jun 26, 2017
@helixbass
support multiple accesses after super [Fixes jashkenas#4591]
4b9605b
This was referenced Jun 30, 2017
Merged
Closed
GeoffreyBooth pushed a commit that referenced this issue Jul 13, 2017
@GeoffreyBooth
[CS2]: Fix #4591: multiple accesses after super (#4592)
852c578 
* support multiple accesses after super [Fixes #4591]

* addtl tests from code review
@GeoffreyBooth
Copy link
Collaborator

Fixed by #4592

@GeoffreyBooth GeoffreyBooth added this to the 2.0.0 milestone Jul 13, 2017
@coffeescriptbot coffeescriptbot mentioned this issue Feb 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@helixbass @GeoffreyBooth