-
-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signal CWD change to terminal via OSC-7 #1148
Conversation
I have merged this PR. I will force push the appropriate changes as well. Please let me know if you see any issues during your tests. |
* Signal CWD change to terminal via OSC-7 Closes #1147 * Make OSC-7 emission gated by NOX11 * Use newpath variable in gethostname() Use dynamic memory for hostname
Please confirm commit 0556ac1 works fine in your tests. |
That commit works fine in both foot, and in gnome-terminal. Technically, the path needs to be URL encoded. In reality, not doing will work in probably 99% of all cases. I tested switching to a directory named I also tested a directory that included a literal It would be fairly simple to implement a URL encoder that allows plain ASCII but On the other hand, if we want to keep things simple, then let's skip URL encoding. The worst thing that happens is the new terminal doesn't spawn in the correct directory. |
That's because by default |
BTW, given the restrictions in |
Then it's all good from my side. |
👍 |
The path still needs to be URL encoded, but this shows the gist of it. Tested in foot only so far. Will hopefully be able to try a few more tomorrow.
TODO
Closes #1147