Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urllib3 should be a mandatory dependency for buku #291

Closed
jarun opened this issue Jul 18, 2018 · 2 comments
Closed

urllib3 should be a mandatory dependency for buku #291

jarun opened this issue Jul 18, 2018 · 2 comments

Comments

@jarun
Copy link
Owner

jarun commented Jul 18, 2018

I think we have urllib3 as an optional dependency in extras section:

https://github.com/jarun/Buku/blob/master/setup.py#L62

I tried installing buku on termux and I had to install urllib3 separately. This needs to be a mandatory dependency.
@jarun
Copy link
Owner Author

jarun commented Jul 18, 2018

@rachmadaniHaryono I have assigned this to you. Please add urllib3 as a mandatory dependency in PyPI. Most things do not work without it.

@jarun jarun closed this as completed in 728e5d4 Jul 18, 2018
@jarun
Copy link
Owner Author

jarun commented Jul 18, 2018

I have added the other 2 deps as mandatory as well.

jarun added a commit that referenced this issue Jul 18, 2018
@jarun
Fix #291: Add deps as mandatory
ab3db30
@maxigaz maxigaz mentioned this issue Jun 4, 2019
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jarun @rachmadaniHaryono