Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Additional Functionality/Helpers + Laravel 5.7 Fix #11

Closed
wants to merge 2 commits into from

Conversation

Braunson
Copy link
Contributor

@Braunson Braunson commented Oct 2, 2018

Includes fix for 5.7 issue laravel/framework#25455

@Braunson Braunson changed the title Adds Additional Functionality/Helpers Adds Additional Functionality/Helpers + Laravel 5.7 Fix Oct 2, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-7.5%) to 54.795% when pulling 94cf386 on Braunson:master into df2e871 on jarektkaczyk:master.

@@ -25,6 +25,8 @@ class ModelLock extends Model
*/
protected static function boot()
{
parent::boot();
Copy link

@damiankloip damiankloip Oct 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider moving this 5.7 fix into into a PR of its own.

Copy link

@dct24 dct24 Nov 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You for the 5.7 fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants