file-entry-cache - fixing bug on save meta.data and changed state #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredwray
deleted the
file-entry-cache---fixing-bug-on-save-meta.data-and-changed-state
branch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #904 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 67 67
=========================================
Hits 67 67 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Jason3S
reviewed
Nov 24, 2024
| const fileDescriptor4 = fileEntryCache3.getFileDescriptor(testFile1); | ||
| expect(fileDescriptor4).toBeDefined(); | ||
| expect(fileDescriptor4.meta.data).toEqual(data2); | ||
| expect(fileDescriptor4.changed).toEqual(true); |
There was a problem hiding this comment.
Why do you expect changed to be true?
The file didn't change. Yes, meta.data had gotten added.
In my case, I only care if the file changed, not the meta.data. I'm ok with being responsible for detecting changes to the meta.data if necessary.
| @@ -288,20 +290,26 @@ export class FileEntryCache { | |||
| return result; | |||
| } | |||
|
|
|||
| if (result.meta.data !== metaCache.data) { | |||
There was a problem hiding this comment.
result.meta.data is always undefined. It is caused by line 262.
fstat = fs.statSync(filePath);
// Get the file size
result.meta = {
size: fstat.size,
};
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
file-entry-cache - fixing bug on save meta.data and changed state #901