Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pymolprobity.tar.gz #9

Merged
merged 2 commits into from
Jun 4, 2019

Conversation

speleo3
Copy link
Contributor

@speleo3 speleo3 commented Jun 4, 2019

The tar.gz file was missing the latest fixes.

I suggest to remove that file at some point in the future. PyMOL's plugin manager should be able to install an archive snapshot from github. Unfortunately, previous versions fail because of the "tests" folder (PyMOL expects a single package, not two), that was fixed in schrodinger/pymol-open-source@4252f8ab145b

The second commit is a cosmetic fix which suppresses a warning about spaces in object names.

speleo3 added 2 commits June 4, 2019 18:11
In the future, this file should be removed in favor of snapshot
downloads from github. Those are installable with the plugin manger, at
least after the following commit:
schrodinger/pymol-open-source@4252f8ab145b
@jaredsampson jaredsampson merged commit ef82dd4 into jaredsampson:master Jun 4, 2019
@jaredsampson
Copy link
Owner

Thanks, Thomas. If I delete the .tar.gz in the future, what would be the best URL to use when installing via the plugin manager?

@speleo3
Copy link
Contributor Author

speleo3 commented Jun 4, 2019

Any of the archive links, e.g. master or a tagged version:

Download, then use "Install from local file" in the plugin manager and browse for the zip file.

jaredsampson added a commit that referenced this pull request Jun 5, 2019
As suggested by Thomas Holder, removing the pymolprobity.tar.gz archive
in favor of the built-in Github branch and release/tag archives. README
and Makefile updated accordingly.

Fixes #9
@rafaeltiveron
Copy link

rafaeltiveron commented Aug 2, 2019

Not working. "Unable to install plugin", message from Pymol. Which is the correct installation for Pymol 2.1.0?

@rafaeltiveron
Copy link

I deleted "test" folder and it installed. Thanks

@speleo3 speleo3 deleted the update-tar-gz branch October 22, 2019 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants