fix: relative links in website to absolute links #923
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/formium/tsdx/qfmj3i24j |
agilgur5
changed the title
|
Supersedes #844 with a valid solution to another issue with #765 , though my remarks in #844 (comment) still stand, especially as the website has no versioning. The website is also a bit outdated now because it was never synced with the README (c.f. #844 (comment), #848). This is still a good change though, so will accept this as incremental improvement even though it does not solve all the problems. |
agilgur5
added
the
scope: docs
|
Another test timeout but only 1 this time. I'll merge since this is quite safe to change, doesn't affect any actual code, and was manually tested. |
|
@allcontributors please add @felixmosh for docs. Thanks for the contribution |
|
I've put up a pull request to add @felixmosh! 🎉 |
- relative links in website were not working as the files can't be viewed
on the site
- these were erroneously copy+pasted from the README, where the relative
links work by pointing to files in the repo
- those relative links don't work on the website
- use absolute links instead to the main fork of the repo's `master` branch
- this has a few caveats now, in that the README has a bit more desync from
the website now and that, unlike the README, these point to a specific
fork and branch
- the README points to the same version; regardless if forked or on a
different branch, it'll point to that branch's code
Maintainer edit:
Closes #844