Fix testMatch to find test files correctly #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem occured in #62 and seems to come from this part: `?(*.)`. Applying the changes in this PR finds the files correctly and runs tests for `.ts` and `.tsx` files inside root and subfolders within `/test/`. Can't check if this still works on other OS than Windows though. ``` PS C:\dev\hidash> npm test > [email protected] test C:\dev\hidash > tsdx test PASS test/blah.test.ts PASS test/fix/make.test.tsx Test Suites: 2 passed, 2 total Tests: 2 passed, 2 total Snapshots: 0 total Time: 3.362s Ran all test suites. ```
jaredpalmer
approved these changes
May 1, 2019
jaredpalmer
changed the title
|
@allcontributors please add @bastibuck for code, bug |
|
I've put up a pull request to add @bastibuck! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem occured in #62 and seems to come from this part:
?(*.). Should fix #62Applying the changes in this PR finds the files correctly and runs tests for
.tsand.tsxfiles inside root and subfolders within/test/.Can't check if this still works on other OS than Windows though.