Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: run tests in series with --runInBand to attempt to fix persistent CI errors #429

Merged
merged 5 commits into from
Jan 13, 2020
Merged

ci: run tests in series with --runInBand to attempt to fix persistent CI errors #429

merged 5 commits into from
Jan 13, 2020

Conversation

jaredpalmer
Copy link
Owner

@jaredpalmer jaredpalmer commented Jan 13, 2020 •
edited
Loading

Adding --runInBand which runs the test in a series instead of in parallel IIRC. This is what I believe was causing the race conditions

@jaredpalmer jaredpalmer changed the title Attempt to fix faulty Jest tests Run tests in series with --runInBand Jan 13, 2020
@jaredpalmer jaredpalmer merged commit 367a7a5 into master Jan 13, 2020
@jaredpalmer jaredpalmer deleted the fix/jest branch January 13, 2020 15:13
@agilgur5 agilgur5 changed the title Run tests in series with --runInBand ci: run tests in series with --runInBand to attempt to fix persistent CI errors Mar 17, 2020
@agilgur5
Copy link
Collaborator

Related to #403 which was a similar attempt.

Root cause of most CI issues (missing *.d.ts type declaration files) was fixed in #504 so this is probably not necessary anymore unless the Windows issue mentioned in #403 (EPERM on creating directories) was fixed by this.
I'm not sure as the errors were different but the missing declaration one happened very frequently and EPERM happened occasionally. EPERM hasn't been seen in a while.

@agilgur5 agilgur5 mentioned this pull request Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredpalmer @agilgur5