Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install tslib by default #72

Closed
aleclarson opened this issue May 1, 2019 · 5 comments · Fixed by #73
Closed

install tslib by default #72

aleclarson opened this issue May 1, 2019 · 5 comments · Fixed by #73
Assignees
@aleclarson

Comments

@aleclarson
Copy link
Contributor

aleclarson commented May 1, 2019 •
edited
Loading

Libraries should be using tslib to eliminate duplicate code.

Also need "importHelpers": true in the tsconfig.json
@jaredpalmer
Copy link
Owner

Agreed

@aleclarson
Copy link
Contributor Author

Hahaha! On it 😆

@swyxio
Copy link
Collaborator

swyxio commented May 1, 2019

lol, power move right there

@aleclarson aleclarson mentioned this issue May 2, 2019
Merged
@aleclarson
Copy link
Contributor Author

@sw-yx a power move, or me being nice? :P

@swyxio
Copy link
Collaborator

swyxio commented May 2, 2019

both :)

@agilgur5 agilgur5 mentioned this issue Mar 6, 2021
Closed
joeflateau pushed a commit to joeflateau/tsdx that referenced this issue Nov 12, 2021
@sidwebworks @aladdin-add
docs: fix & deploy the docs to gh page
16bb5a3 
Squashed commits:
[412069f] docs: fix stroke-width => strokeWidth
[33f60c0] docs: update template/website documentation (jaredpalmer#73)
[544bbce] Delete documentation.yml
[b28416f] Revert "Documentation Fix (jaredpalmer#69)" (jaredpalmer#72)

This reverts commit d82864d.
[d82864d] Documentation Fix (jaredpalmer#69)

* 📖 Fixed documentation website

* working on Deployment errors

* switching to github pages

* test deploy
[8a4d3b3] Update documentation.yml (+1 squashed commit)
Squashed commits:
[99cc817] Create documentation.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aleclarson aleclarson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use tslib by default aleclarson/tsdx
3 participants
@aleclarson @jaredpalmer @swyxio