Icons showing shares when settings is None

[JiveDig]

Discussed with Bill already. I think i found the issue and will submit a PR in a min. Feel free to edit as needed.

Putting this here to reference the PR against.

[JiveDig]

[JiveDig]

Any chance of getting this merged/tested? Just about to launch the new theme (screenshot above) for them and hitting this on live.

[billerickson]

Sorry for the delay on this.

I'm having trouble reproducing the error. When I select "None" as the count and "Fancy" as the style, I don't get any counts displayed.

There's no markup appearing for the count:

The logic for removing the count markup is here. It's a bit confusing because both of these options reference settings that are hidden if you have "None" as your count source.

I was able to replicate your screenshot with the following workflow:

• Go to Settings > Shared Counts
• Select "SharedCount.com" as the count source
• Uncheck "Count Total Only" and "Hide Empty Counts"
• Select "None" as the count source
• Click "Save Changes"

Rather than using CSS to hide the count if "None" is selected, I think we should extend the current approach to exclude the count markup if "None" is selected.

Can you test the issue/81 branch and see if it resolves the issue for you? Here's the relevant addition: 6d75ef1