Add toml to setup_requires #30
Conversation
|
|
|
This is actually required for building a wheel from an sdist. jaraco/skeleton#12 is also needed to fix the linked error but with the PR here, |
|
No, it’s not required for building a wheel from an sdist. The reason it doesn’t work is the toml library is not available at build time. |
seppeljordan
force-pushed
the
fix-missing-version
branch
from
febadca to
590d6d4
Compare
seppeljordan
changed the title
|
I edited the PR that follows the advice from the previous comment by @layday |
|
It is very much not my place to review this PR but: (a) this latest change places a hard dependency on the toml package; (b) it should also be reflected in pyproject.toml; and (c) jaraco/skeleton#12 accomplishes the same thing, and should it be merged, I presume it'll also be merged back into zipp. |
|
Fixed in 955cc9f. Thanks for the report. |
* Replace pep517.build with build Resolves #30 * Prefer simple usage Co-authored-by: Jason R. Coombs <[email protected]>
* Use `extend-ignore` in flake8 config This option allows to add extra ignored rules to the default list instead of replacing it. The default exclusions are: E121, E123, E126, E226, E24, E704, W503 and W504. Fixes #28. Refs: * https://github.com/pypa/setuptools/pull/2486/files#r541943356 * https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-extend-ignore * https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-ignore * Enable complexity limit. Fixes jaraco/skeleton#34. * Replace pep517.build with build (#37) * Replace pep517.build with build Resolves #30 * Prefer simple usage Co-authored-by: Jason R. Coombs <[email protected]> * Use license_files instead of license_file in meta (#35) Singular `license_file` is deprecated since wheel v0.32.0. Refs: * https://wheel.readthedocs.io/en/stable/news.html * https://wheel.readthedocs.io/en/stable/user_guide.html#including-license-files-in-the-generated-wheel-file Co-authored-by: Jason R. Coombs <[email protected]>
EDITED!
This PR makes toml available to setuptools add build time. This should fix an issue that would result in distributions with the version
0.0.0.