Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a license file #8

Merged
merged 1 commit into from
Dec 6, 2016
Merged

Provide a license file #8

merged 1 commit into from
Dec 6, 2016

Conversation

stratakis
Copy link
Contributor

While MIT is mentioned as a license for the project, the file is actually not included.

@jakirkham jakirkham mentioned this pull request Nov 12, 2016
@jakirkham
Copy link

Could you please add it to MANIFEST.in too?

@jakirkham
Copy link

cc @astaric

@jaraco
Copy link
Owner

jaraco commented Dec 6, 2016

jaraco/skeleton#1

@jaraco jaraco closed this Dec 6, 2016
@jakirkham
Copy link

Much like our discussion in issue ( pypa/setuptools#612 ), I maintain the same opinion for the same reason here. To briefly list them, here they are.

  1. The MIT license requires it. (Quote below)
  2. As noted by Ian, legal departments depend on this structure of licensing to determine what can be used.

Given the legwork has already be done in this PR, please reconsider. Would happily address the MANIFEST.in in a follow up PR.

The above copyright notice and this permission notice shall be included
in all copies or substantial portions of the Software.

ref: https://opensource.org/licenses/MIT

@jaraco jaraco reopened this Dec 6, 2016
@jaraco
Copy link
Owner

jaraco commented Dec 6, 2016

As long as there are people willing to maintain it and it doesn't cause me any additional burden, I'll allow it to exist.

@jaraco
Copy link
Owner

jaraco commented Dec 6, 2016

Well already, I'm stymied. The tests are failing so I can't merge from my phone. I'll have to revisit this another time.

@jakirkham jakirkham mentioned this pull request Dec 6, 2016
@jaraco jaraco merged commit 6412de6 into jaraco:master Dec 6, 2016
jaraco added a commit that referenced this pull request Dec 9, 2016
jaraco added a commit that referenced this pull request Sep 25, 2020
Co-authored-by: Jason R. Coombs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants