Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove filename spaces for Bazel #12

Closed
wants to merge 1 commit into from

Conversation

arrdem
Copy link

@arrdem arrdem commented Jun 3, 2023

Just what it says on the tin.

Spaces in filesystem paths work... but have a lot of caveats. Enough caveats that some build systems (cough bazel cough) just don't even try to support them.

This patch simply renames the lorem-ipsum resource file so that it no longer has a space and enables jaraco.text to build with the expected behavior under Bazel.

@jaraco
Copy link
Owner

jaraco commented Jul 30, 2023

Thanks for the suggestion, but I'm firmly of the position that spaces are valid characters in filenames and build tools should support it. Spaces have been valid characters in filenames in posix systems since before I started my CS studies in the early 90's, and they've been valid filenames in Windows since 1995. I don't want to lose the ability to make use of these filenames where appropriate.

See pypa/setuptools#134 for more rationale.

It seems wrong for a tool like bazel to bully all projects into conforming to their over-constrained view of the world. Instead, bazel should support legitimate filenames and if it doesn't, its users should be expected to provide the adaptation from legitimate filenames to compatible ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants