Added support to Sublime Text with .lua files #55
Conversation
| { | ||
| "pico8-lua": { | ||
| "enabled": true, | ||
| "command": ["pico8-ls","--stdio"], |
There was a problem hiding this comment.
Instead of making a new executable file like above, wouldn't it be simpler to have this command point to the right place?
Does Sublime Text not have any way to install a plugin? are all language servers this janky to install?
There was a problem hiding this comment.
Hi,
in sublime text there is a plugin called LSP that manages the lsp servers. In the docs appears:
A subprocess is always started. There is no support for connecting to a remote language server.
You can use tcp instead stdio to communicate with the server, but I don't know if that would be a better solution.
server/package-lock.json
Outdated
There was a problem hiding this comment.
I'm sure you didn't mean to just completely delete this file ...
There was a problem hiding this comment.
Yeah, this was a mistake, I reverted the commit.
| @@ -15,6 +15,7 @@ | |||
| "author": "JanPaul Bergeson", | |||
| "license": "MIT", | |||
| "devDependencies": { | |||
| "@types/jest": "^29.5.12", | |||
There was a problem hiding this comment.
The problem is that if you try to compile the ts scripts with npm run compile, you get a lot of errors related with the tests:
src/parser/test/formatter.test.ts:633:5 - error TS2582: Cannot find name 'it'. Do you need to install type definitions for a test runner? Try `npm i --save-dev @types/jest` or `npm i --save-dev @types/mocha`.
633 it('preserves comments after statements', () => {
this is why I added the dependency, so I could compile and continue with the process. Maybe there is some alternative to compile without the tests? but I think that it would be required to touch the package.json anyway.
|
Thanks for the contribution! I've looked through the changes and made a few comments that I'd like to see addressed before merging this. |
This reverts commit f4a0b9e.
|
Closing this as it's been a long time since the last update. It can still serve as a good starting point for anyone else who might want to add better docs for Sublime support. See my comments on this PR as to what still needs to be done/discussed. Also, i'm happy to re-open if the original author wants to continue working on this branch. |
This version allows to use pico8-ls with sublime text to edit .lua files. The only problem with the original code was some console prints, unexpected by the sublime LSP plugin.