Update www/importentity.php #603
Conversation
[Wed Sep 21 15:35:30 2016] [error] [client 10.68.130.101] PHP Fatal error: Call to undefined method SimpleSAML_Session::getInstance() in /apps/janus/janus-1.22.0/www/importentity.php on line 15 I think this one wasn't fixed properly to support SSP 1.1.14
|
Yes, it is. He used an SimpleSAML_Auth_Simple object to replace the deprecated SimpleSAML_Session::getInstance(), but that object doesn't define the getValue/setValue methods used a bit further down in this file. |
|
After reading the deprecation notice of SimpleSAML_Session::getInstance() and this post by @jaimeperez, I really think @mrvanes has approached the whole sessionfix-patch the wrong way. Perhaps Jaime can comment on this. |
|
@mrvanes and I agreed on a mix of both worlds.. This has been tested and works / fixes the build. |
| @@ -26,7 +26,7 @@ | |||
| $as = new SimpleSAML_Auth_Simple($authsource); | |||
There was a problem hiding this comment.
So we instantiate $as with an $authsource (where does that come from?) and right below now pass $authenticationSource. Is that really correct?
There was a problem hiding this comment.
No, sorry, I messed up..
I messed up
[Wed Sep 21 15:35:30 2016] [error] [client 10.68.130.101] PHP Fatal error: Call to undefined method SimpleSAML_Session::getInstance() in /apps/janus/janus-1.22.0/www/importentity.php on line 15
I think this one wasn't fixed properly to support SSP 1.1.14