Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): updates topology and tekton plugin #964

Merged

Conversation

invincibleJai
Copy link
Member

Description

Update topology and tekton plugin to include the latest features and fixes.

Which issue(s) does this PR fix

Toplogy Features:

  • fix to layout nodes correctly on first load (#1194)
  • stop polling after log streaming completes (#1122)
  • added default runtime icon to topology nodes (#1157)

Tekton Features:

  • fix #922 and #962 by using full width for pipeline visualization
  • external sbom view action should not open logs modal (#1152)
  • fix #947: Reset pagination when changing any filter (#1140)
  • stop polling after log streaming completes (#1122)

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@invincibleJai invincibleJai requested a review from a team as a code owner February 13, 2024 07:34
Copy link

changeset-bot bot commented Feb 13, 2024

🦋 Changeset detected

Latest commit: 2a74171

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
dynamic-plugins-imports Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@openshift-ci openshift-ci bot requested review from nickboldt and tumido February 13, 2024 07:34
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
1.3% Duplication on New Code

See analysis details on SonarCloud

@invincibleJai
Copy link
Member Author

invincibleJai commented Feb 13, 2024

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-964!

@karthikjeeyar
Copy link
Contributor

Tested locally, everything works as expected.

/lgtm

Copy link
Member

@gashcrumb gashcrumb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, 👍

@gashcrumb
Copy link
Member

/approve

Copy link

openshift-ci bot commented Feb 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: gashcrumb, karthikjeeyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1cb3eba into janus-idp:main Feb 13, 2024
6 checks passed
@invincibleJai invincibleJai deleted the update-topology-tekton-13 branch February 14, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants