-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update scalprum dependecies versions #925
Conversation
🦋 Changeset detectedLatest commit: 3021d72 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Martin Marosi <[email protected]>
19d0924
to
3021d72
Compare
Quality Gate failedFailed conditions 3.7% Duplication on New Code (required ≤ 3%) |
The image is available at: |
/lgtm |
@gashcrumb any idea why is the OCP/PR Test failing? I don't have access to the IBM cloud. |
Yep, lemme check, though I think at the moment it's expected that they'll fail. I tested this locally and see no problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested it locally, and it seems to work now. Not sure why the tests e2e-tests are failing at the moment as it seems like it wasn't able to access the UI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was told by QE that we can ignore the e2e tests for now. They don't have it fully setup.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gashcrumb, schultzp2020 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This is an issue with yarn and how its dependency deduplication works. The problems are exacerbated in mono repositories.
Why was this an issue?
The scallprum test utils package has the following scalprum core version requirement:
Ant version
0.*.*
is compatible with the packages. However by locking the@scalprum/core
dependency to0.7.0
will result in the following dependency tree in the package:I've released versions that strictly require the latest versions of Scalprum. However, this is not an ideal solution. We might have to add yarn resolutions to ensure only actually installed packages is being used. OR switch to npm.
More information about the deduplication issues for nested dependencies can be found here: yarnpkg/yarn#3778