Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(notifications): add Notifications plugins to container image #896

Closed
wants to merge 1 commit into from
Closed

feat(notifications): add Notifications plugins to container image #896

wants to merge 1 commit into from

Conversation

mareklibra
Copy link

@mareklibra mareklibra commented Jan 23, 2024 •
edited
Loading

Description

By this change, the Notifications dynamic plugins are included in the backstage-showcase container image, disabled by default.

Requires:

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Screenshot from 2024-01-25 12-17-34

Screencast.from.2024-01-25.12-16-01.webm

@mareklibra mareklibra requested a review from a team as a code owner January 23, 2024 12:32
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a0392b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@openshift-ci openshift-ci bot requested review from kadel and tumido January 23, 2024 12:32
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zaperex for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mareklibra mareklibra force-pushed the notificationsInHelmChart branch from 37032a0 to 76f11d1 Compare January 24, 2024 14:42
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-896!

@janus-idp Janus IDP
Copy link
Contributor

janus-idp bot commented Jan 24, 2024 •
edited
Loading

backstage-showcase Tests on commit 949ebb7 finished successfully.
View test log

@mareklibra mareklibra force-pushed the notificationsInHelmChart branch from b26827c to 44ce8b4 Compare January 25, 2024 10:18
@mareklibra
Copy link
Author

Rebased

@mareklibra mareklibra force-pushed the notificationsInHelmChart branch from 44ce8b4 to 60076a3 Compare January 25, 2024 10:19
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-896!

@mareklibra mareklibra force-pushed the notificationsInHelmChart branch from 60076a3 to ab30a08 Compare January 25, 2024 14:53
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-896!

@mareklibra mareklibra force-pushed the notificationsInHelmChart branch from ab30a08 to 3de0cb7 Compare January 26, 2024 08:51
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-896!

@mareklibra mareklibra force-pushed the notificationsInHelmChart branch from 3de0cb7 to 316894f Compare January 29, 2024 07:59
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-896!

@nirfarkas
Copy link

Looks nice!
One comment:
I don't think the "Sort by" belongs under the "Filters" section.

@mareklibra mareklibra force-pushed the notificationsInHelmChart branch from 316894f to 9b5c589 Compare January 31, 2024 06:58
@mareklibra
Copy link
Author

Rebased

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-896!

@mareklibra mareklibra force-pushed the notificationsInHelmChart branch from 9b5c589 to bcfe924 Compare February 1, 2024 07:24
@mareklibra
Copy link
Author

Rebased

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-896!

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-896!

@mareklibra mareklibra force-pushed the notificationsInHelmChart branch from 308db2a to a0392b4 Compare February 19, 2024 07:06
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nickboldt
Copy link
Member

Closing since notifications moved to upstream backstage/backstage and so I'm assuming this is outdated. @mareklibra if that's an error, LMK.

@nickboldt nickboldt closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfestal davidfestal davidfestal left review comments

@masayag masayag masayag left review comments

@kadel kadel Awaiting requested review from kadel

@tumido tumido Awaiting requested review from tumido

Assignees
No one assigned
Labels
needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mareklibra @nirfarkas @openshift-merge-robot @nickboldt @masayag @davidfestal