Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(servicenow-actions): revert node-fetch dep #973

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

davidfestal
Copy link
Member

@davidfestal davidfestal commented Nov 28, 2023

Revert the node-fetch dependency to the 2.7.0 version, in order to fix the incompatibility with ES-only modules (we use the require() call).

cf. https://bobbyhadz.com/blog/javascript-error-err-require-esm-require-of-es-module-not-supported#node-fetch-error-err_require_esm-require-of-es-module-not-supported

This fixes issue #976

to the `2.7.0` version to fix the incompatibility with
ES-only modules (we use the `require()` call).

Signed-off-by: David Festal <[email protected]>
@davidfestal davidfestal requested a review from a team as a code owner November 28, 2023 10:24
@davidfestal davidfestal requested review from tumido and kadel November 28, 2023 10:24
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@davidfestal davidfestal linked an issue Nov 28, 2023 that may be closed by this pull request
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@tumido tumido merged commit 94bedf9 into janus-idp:main Nov 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible to load the ServiceNow action as a dynamic plugin
2 participants