feat: adds storybook #956
feat: adds storybook #956
Conversation
|
@tumido FYI ^^ |
jkilzi
force-pushed
the
tasks/upstream/FLPATH-701
branch
from
e9578ed to
fb23c21
Compare
jkilzi
force-pushed
the
tasks/upstream/FLPATH-701
branch
4 times, most recently
from
183177c to
c5285df
Compare
FLPATH-701 chore: address PR issues Changes: 1. Removes the examples directory and related code. 2. Removes @storybook/addon-onboarding 3. Updates deps: @testing-library/jest-dom": "^5.17.0, @backstage/test-utils": "^1.4.4 4. Removes custom prettier config inside the storybook package 5. Fixes code-style issues docs: updates Storybook's README file chore: ignore .idea/ folder
jkilzi
force-pushed
the
tasks/upstream/FLPATH-701
branch
from
c5285df to
9804f58
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
@invincibleJai I'd like to mark the conversation as resolved, do you have anything to add? |
HI @jkilzi, I have looked at it and will try it. Would be nice to have some components as part of the story book as a starting point and I would like some more eyes on this as this would be used by any other plugins to contribute in the future. currently team is a bit occupied so expect some delays |
You can also see it in action in this PR caponetto#24, I implemented a story for the Orchestrator plugin there |
|
@invincibleJai do you want any more 👀 on this or are we fine to merge it? 🙂 I've resolved the conversations above, the justification provided by @jkilzi makes sense to me. I don't want to hold the team hostage by our release more than necessary and the code looks good to me. 🙂 |
|
/lgtm |
FLPATH-701
This PR adds Storybook. A playground for testing and developing UI components in isolation.
Usage
Two new top-level scripts where added:
start:storybookandbuild:storybook, the later builds a static website which is useful for showcasing Storybook's stories.Notes:
plugins/<plugin-name>is passed, the process will scan for stories inside each plugin workspace.yarn build:storybook [plugins/<frontend-plugin-name>].This command produces a directory called
packages/storybook/storybook-static. This directory can be then renderedusing a static web server.
Resources