fix(aap+3scale+ocm): don't log sensitive data from errors #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christoph-jerolimov
requested review from
gorkem,
AndrienkoAleksandr,
PatAKnight,
a team and
fmenesesg
as code owners
christoph-jerolimov
requested review from
invincibleJai,
tumido and
schultzp2020
Signed-off-by: Christoph Jerolimov <[email protected]>
christoph-jerolimov
force-pushed
the
do-not-log-full-error-objects
branch
from
779efe8 to
915e150
Compare
|
SonarCloud Quality Gate failed.
|
|
Please don't forget to update aap and ocm plugins in showcase repo after this is merged. |
5 tasks
This was referenced Oct 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies a similar change as #938 to the same issues for AAP, 3Scale, and OCM providers.
Changes:
AapResourceEntityProvider.test.tswhere I could confirm that the auth header was logged before. 3scale and OCM don't have unit tests for the Providers to confirm the change.logger.errorstatements. As best practice to make it easier find the right log statement and also to make it more compatible with backstage LoggerService.