Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rbac): list roles #937

Merged
merged 1 commit into from
Nov 28, 2023
Merged

feat(rbac): list roles #937

merged 1 commit into from
Nov 28, 2023

Conversation

debsmita1
Copy link
Member

@debsmita1 debsmita1 commented Nov 15, 2023

Resolves:
#843

Screenshots/GIF:
Screenshot 2023-11-15 at 5 09 39 PM

User not authorized to delete roles

Test setup:
Add this in the rbac-policy.csv
p, user:default/<username>, policy-entity, delete, deny

Screenshot 2023-11-22 at 11 46 59 PM

Screen.Recording.2023-11-27.at.7.33.13.PM.mov

Screenshot 2023-11-27 at 7 32 28 PM

Test setup:

Follow the steps mentioned in the PR #895 and the documentation to install the RBAC UI plugin

@debsmita1 debsmita1 requested a review from a team as a code owner November 15, 2023 11:49
@debsmita1 debsmita1 linked an issue Nov 15, 2023 that may be closed by this pull request
4 tasks
@debsmita1 debsmita1 changed the title feat(rbac): List roles feat(rbac): list roles Nov 15, 2023
@debsmita1 debsmita1 force-pushed the role-list branch 7 times, most recently from c094685 to 411fe69 Compare November 15, 2023 18:02
@debsmita1 debsmita1 force-pushed the role-list branch 2 times, most recently from 1f2ade8 to 56a8e90 Compare November 20, 2023 12:26
plugins/rbac/src/hooks/useRoles.ts Show resolved Hide resolved
plugins/rbac/src/hooks/useRoles.ts Outdated Show resolved Hide resolved
plugins/rbac/src/utils/rbac-utils.ts Outdated Show resolved Hide resolved
plugins/rbac/src/utils/rbac-utils.ts Outdated Show resolved Hide resolved
@debsmita1 debsmita1 force-pushed the role-list branch 5 times, most recently from 1893b43 to bb5946f Compare November 22, 2023 13:19
@debsmita1
Copy link
Member Author

Updated the GIF @parvathyvr @invincibleJai @divyanshiGupta

@parvathyvr
Copy link

parvathyvr commented Nov 22, 2023

@debsmita1 some of the updates to this design are

  1. Column name - Members changed to 'Users and groups'
  2. Column name- Permission changed to 'Permission policies'
  3. Delete icon will be shown all times- if user do not have delete access- we plan to show the delete icon disabled with a tooltip explanation. Figma link
  4. The delete modal-included some more context info for the user- referring to the part where we talk about the users and permission policies in that role Eg: 'The 5 users and 12 groups associated with this role will lose access to all the 3 permission policies specified in this role.' Figma link
  5. Error scenario in modal design updated- Figma link OR see the generic error message mockup

Let me know if there are any questions-Thank you!

@debsmita1 debsmita1 force-pushed the role-list branch 3 times, most recently from ad48dc3 to c5f50eb Compare November 22, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RBAC Plugin] Show list of Roles in table with actions to delete
6 participants