feat(cli): add flags to handle native deps #2567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gashcrumb
requested review from
davidfestal,
jesuino and
kadel
as code owners
🦋 Changeset detectedLatest commit: d283433 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gashcrumb
force-pushed
the
RHIDP-5062
branch
2 times, most recently
from
854b560 to
439c962
Compare
gashcrumb
changed the title
gashcrumb
force-pushed
the
RHIDP-5062
branch
from
439c962 to
90285e4
Compare
gashcrumb
force-pushed
the
RHIDP-5062
branch
2 times, most recently
from
8be7a10 to
1eccb58
Compare
This change introduces two new flags to the CLI to handle transitive dependencies on packages containing native modules. `--allow-native-package [package-name...]` to selectively allow native packages when exporting a dynamic plugin and allowing it's installation into the exported dynamic plugin and `--suppress-native-package [package-name..]` which replaces the native package with an empty package during export, preventing the native package's inclusion into the exported dynamic plugin's private dependencies. Signed-off-by: Stan Lewis <[email protected]>
gashcrumb
force-pushed
the
RHIDP-5062
branch
from
1eccb58 to
d283433
Compare
|
davidfestal
approved these changes
Nov 27, 2024
| path.join(target, 'embedded', toSuppress, 'index.js'), | ||
| ` | ||
| throw new Error( | ||
| 'The package "${toSuppress}" has been marked as a native module and removed from this dynamic plugin package "${derivedPackageName}"' |
There was a problem hiding this comment.
Maybe add the fact that it is throwing an error because loading native modules from a dynamic backend plugin is currently not supported ?
schultzp2020
pushed a commit
that referenced
this pull request
Nov 27, 2024
This change introduces two new flags to the CLI to handle transitive dependencies on packages containing native modules. `--allow-native-package [package-name...]` to selectively allow native packages when exporting a dynamic plugin and allowing it's installation into the exported dynamic plugin and `--suppress-native-package [package-name..]` which replaces the native package with an empty package during export, preventing the native package's inclusion into the exported dynamic plugin's private dependencies. Signed-off-by: Stan Lewis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces two new flags to the CLI to handle transitive dependencies on packages containing native modules.
--allow-native-package [package-name...]to selectively allow native packages when exporting a dynamic plugin and allowing it's installation into the exported dynamic plugin and--suppress-native-package [package-name..]which replaces the native package with an empty package during export, preventing the native package's inclusion into the exported dynamic plugin's private dependencies.