Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): update RBAC to delivery bug fixes for RHDH 1.3.1 #2375

Merged

Conversation

AndrienkoAleksandr
Copy link
Collaborator

What does this pull request fixes:

Fixes https://issues.redhat.com/browse/RHIDP-4069

@AndrienkoAleksandr AndrienkoAleksandr requested review from PatAKnight and a team as code owners October 17, 2024 16:48
Copy link

changeset-bot bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: a67e420

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@janus-idp/backstage-plugin-rbac-backend Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AndrienkoAleksandr AndrienkoAleksandr changed the title Update RBAC to delivery bug fixes for RHDH 1.3.1 chore(release): update RBAC to delivery bug fixes for RHDH 1.3.1 Oct 22, 2024
Copy link
Member

@PatAKnight PatAKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that there are a number of unnecessary changes in this PR. We just need to backport the fix ownerRefs and allow to disable group inheritance PRs. Is there any reason that we need to include the changes to audit log, rbac common, rbac node, and rbac plugins?

.changeset/fuzzy-dryers-lie.md Outdated Show resolved Hide resolved
plugins/rbac-backend/package.json Outdated Show resolved Hide resolved
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Member

@PatAKnight PatAKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@PatAKnight
Copy link
Member

/override "SonarCloud Code Analysis"

Copy link

openshift-ci bot commented Oct 23, 2024

@PatAKnight: Overrode contexts on behalf of PatAKnight: SonarCloud Code Analysis

In response to this:

/override "SonarCloud Code Analysis"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit e02e4d5 into janus-idp:release-1.3 Oct 23, 2024
11 of 12 checks passed
@schultzp2020 schultzp2020 mentioned this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants