Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kiali): include Kiali external URL as a parameter #1835

Merged
merged 4 commits into from
Jun 24, 2024

Conversation

josunect
Copy link
Contributor

@josunect josunect commented Jun 21, 2024

    kiali:
      # Required. Kiali endpoint
      url: ${KIALI_BASE_URL}
      # Optional. Kiali public URL to redirect to standalone Kiali. When not specified, url will be used.
      urlExternal: ''

This URL is also displayed in the about window, it can be used to verify:

image

  • Added some test coverage for resources card.

@josunect josunect marked this pull request as ready for review June 21, 2024 13:56
@josunect josunect requested review from a team as code owners June 21, 2024 13:56
Copy link
Contributor

@aljesusg aljesusg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

Copy link

openshift-ci bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aljesusg
Once this PR has been reviewed and has the lgtm label, please assign davidfestal for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aljesusg aljesusg merged commit 6dbe9eb into janus-idp:main Jun 24, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants