Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(orchestrator): add dependency to orchestrator-common in turbo #1723

Merged
merged 1 commit into from
May 27, 2024
Merged

chore(orchestrator): add dependency to orchestrator-common in turbo #1723

merged 1 commit into from
May 27, 2024

Conversation

gciavarrini
Copy link
Contributor

@gciavarrini gciavarrini commented May 27, 2024

Fix build/test error due to missing dependency.

@janus-idp/backstage-plugin-orchestrator-backend:export-dynamic
cache bypass, force executing 35e60e6553d858b4
$ janus-cli package export-dynamic-plugin
Embedding module @janus-idp/backstage-plugin-orchestrator-common

Error: Error: Could not resolve './generated/client' from ../orchestrator-common/src/index.ts

@gciavarrini gciavarrini changed the title Add common dependency in turbo chore(orchestrator): add common dependency in turbo May 27, 2024
Signed-off-by: Gloria Ciavarrini <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.8% Duplication on New Code

See analysis details on SonarCloud

@gciavarrini gciavarrini changed the title chore(orchestrator): add common dependency in turbo chore(orchestrator): add dependency to orchestrator-common in turbo May 27, 2024
@gciavarrini gciavarrini marked this pull request as ready for review May 27, 2024 16:46
@gciavarrini gciavarrini requested review from a team as code owners May 27, 2024 16:46
@kim-tsao
Copy link
Member

/lgtm
/approve

Copy link

openshift-ci bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kim-tsao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ccd80db into janus-idp:main May 27, 2024
15 checks passed
ciiay pushed a commit to ciiay/backstage-plugins that referenced this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants