Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @testing-library/react to v14 #138

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 18, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@testing-library/react 12.1.5 -> 14.0.0 age adoption passing confidence
@testing-library/react 13.4.0 -> 14.0.0 age adoption passing confidence

Release Notes

testing-library/react-testing-library

v14.0.0

Compare Source

Bug Fixes
Features
BREAKING CHANGES

v13.4.0

Compare Source

Features
  • renderHook: allow passing of all render options to renderHook (#​1118) (27a9584)

v13.3.0

Compare Source

Features

v13.2.0

Compare Source

Features

v13.1.1

Compare Source

Bug Fixes

v13.1.0

Compare Source

Features

v13.0.1

Compare Source

Bug Fixes

v13.0.0

Compare Source

Features
BREAKING CHANGES

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

tumido
tumido previously approved these changes Feb 21, 2023
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@renovate renovate bot force-pushed the renovate/testing-library-react-14.x branch 3 times, most recently from 3544954 to 8586a95 Compare February 28, 2023 22:08
@renovate renovate bot force-pushed the renovate/testing-library-react-14.x branch from 8586a95 to aab3cf7 Compare March 14, 2023 19:24
@tumido
Copy link
Member

tumido commented Mar 20, 2023

We actually need to downgrade this for now (and lock to ^v12) until React v18. See changelog for more details.

@tumido tumido closed this Mar 20, 2023
@renovate
Copy link
Contributor Author

renovate bot commented Mar 20, 2023

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 14.x releases. But if you manually upgrade to 14.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/testing-library-react-14.x branch March 20, 2023 14:57
tumido added a commit that referenced this pull request Mar 21, 2023
Related to: #138
#41

Unifies the `@testing-library/react` versions (Topology plugin is
already [on this exact
version](https://github.com/janus-idp/backstage-plugins/blob/6f1e02ff7c55d32bab4d99afab832dd89d9fa9cf/plugins/topology/package.json#L59)).

This is necessary until we can support React v18. The v13 of
`@testing-library/react`
[drops](https://github.com/testing-library/react-testing-library/releases/tag/v13.0.0)
support for v17.

Signed-off-by: Tomas Coufal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant