-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kiali): add corner cases, fix some issues and improve dev env #1202
Merged
openshift-merge-bot
merged 3 commits into
janus-idp:main
from
aljesusg:_corner_cases_kiali
Feb 14, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
# Kiali Plugin in Red Hat Developer hub | ||
|
||
The Kiali plugin is in the Red Hat Developer Hub for OpenShift users of Istio/OSSM. It is Technology Preview and provides early access to potential product features, enabling users to test features and provide feedback during the development process. Because this is a brand new offering, there are some things you should consider: | ||
|
||
It is based on the new dynamic plugin-in framework. | ||
Because it is currently a Technology Preview, we are not yet ready to provide official support, and it is not subject Red Hat production service level agreements (SLAs). | ||
With that said, the Kiali team hopes that the community will try out the new Kiali Plugin in Red Hat Developer Hub and provide feedback. We thank you for joining the effort to provide Kiali/Service Mesh observability features directly to the Red Hat Developer Hub. | ||
|
||
## Install | ||
|
||
To install Kiali we need to modify the helm chart and add these values under global > dynamic > plugins | ||
|
||
```yaml | ||
global: | ||
dynamic: | ||
includes: | ||
- dynamic-plugins.default.yaml | ||
plugins: | ||
- disabled: false | ||
integrity: <Checksum> | ||
package: '@janus-idp/backstage-plugin-kiali@<version>' | ||
pluginConfig: | ||
dynamicPlugins: | ||
frontend: | ||
janus-idp.backstage-plugin-kiali: | ||
appIcons: | ||
- importName: KialiIcon | ||
name: kialiIcon | ||
dynamicRoutes: | ||
- importName: KialiPage | ||
menuItem: | ||
icon: kialiIcon | ||
text: Kiali | ||
path: /kiali | ||
- disabled: falseName of the contact in Engineering | ||
integrity: <Checksum> | ||
package: '@janus-idp/backstage-plugin-kiali-backend-dynamic@<version>' | ||
pluginConfig: | ||
catalog: | ||
providers: | ||
kiali: | ||
skipTLSVerify: true | ||
url: '${KIALI_ENDPOINT}' | ||
serviceAccountToken: '${KIALI_SERVICE_ACCOUNT_TOKEN}' | ||
``` | ||
|
||
_integrity: required for external packages) An integrity checksum in the format of <alg>-<digest> specific to the package. Supported algorithms include sha256, sha384, and sha512._ | ||
|
||
We can calculate the integrity with the next bash commands (Example with version 1.9.0). | ||
|
||
```bash | ||
|
||
npm pack @janus-idp/[email protected] | ||
echo "sha512-$(cat janus-idp-backstage-plugin-kiali-backend-dynamic-1.9.0.tgz | openssl dgst -sha512 -binary | openssl base64 -A)" | ||
|
||
``` | ||
|
||
_The mountPoints configuration is not available in the tech preview, we’ll use this to configure the kiali view by entity_ | ||
|
||
## Kiali Page | ||
|
||
### Overview Page | ||
|
||
![overview](./images/rhdh/RHDH_kiali_page_overview.png) | ||
|
||
### Workloads List | ||
|
||
![workloads](./images/rhdh/RHDH_kiali_page_workloads.png) | ||
|
||
### Video Demo | ||
|
||
[![RHDH-demo](https://img.youtube.com/vi/jCExpeXl9A8/0.jpg)](https://youtu.be/jCExpeXl9A8) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"verify": false, | ||
"missingAttributes": ["serviceAccountToken"], | ||
"message": "Attribute 'serviceAccountToken' is not in the backstage configuration", | ||
"helper": "For more information follow the steps in https://janus-idp.io/plugins/kiali", | ||
"authData": { "strategy": "token", "sessionInfo": {} } | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes
File renamed without changes
File renamed without changes
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
import React from 'react'; | ||
|
||
import { | ||
Content, | ||
MissingAnnotationEmptyState, | ||
Page, | ||
} from '@backstage/core-components'; | ||
|
||
import { ANNOTATION_SUPPORTED } from '../../Router'; | ||
|
||
export const KialiNoAnnotation = () => { | ||
return ( | ||
<Page themeId="tool"> | ||
<Content> | ||
<MissingAnnotationEmptyState | ||
annotation={ANNOTATION_SUPPORTED} | ||
readMoreUrl="https://github.com/janus-idp/backstage-plugins/blob/main/plugins/kiali/README.md" | ||
/> | ||
</Content> | ||
</Page> | ||
); | ||
}; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is not subject to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well this was correct by editors in post https://medium.com/kialiproject/kiali-setup-in-red-hat-developer-hub-57502ea8b988 it's copy/paste it seems that this is right