test(quay): add first playwright tests #1201
Conversation
|
/cc @karthikjeeyar |
|
Thanks @jrichter1, This looks good. would be good to update Locally i needed to install playwright as well
|
| name: Playwright tests | ||
|
|
||
| on: | ||
| pull_request: |
There was a problem hiding this comment.
as this workflow runs on pull_request so does that run for quay only if changes are in quay plugin or even if it's not changed?
There was a problem hiding this comment.
right now it will run for all plugins that have the ui-test npm script, regardless of changes
I can try skipping unchanged plugins if this is an issue.
There was a problem hiding this comment.
That would be nice if we can run It based on change
There was a problem hiding this comment.
I've changed the job to first look for any suitable plugins that have changed in the PR. Unchanged plugins should now be ignored, and the whole test run will be skipped if no changes in relevant plugins are detected (if it works properly).
jrichter1
force-pushed
the
plugin-tests
branch
from
e8f2e13 to
3248a78
Compare
updated |
| }); | ||
|
|
||
| test('Vulnerabilities are listed', async () => { | ||
| const severity = ['High:', 'Medium:', 'Low:']; |
There was a problem hiding this comment.
how is the data being fetched, will it change with time are always have these severities?
There was a problem hiding this comment.
it is being fetched from a quay repo that I've made for this reason. The way I see it, if the image doesn't get updated, the number of vulnerabilities should not decrease. As far as the test cares, the number just needs to stay above zero.
There was a problem hiding this comment.
yeah, it doesn't change with time then it should be good.
| /** | ||
| * See https://playwright.dev/docs/test-configuration. | ||
| */ | ||
| export default defineConfig({ |
There was a problem hiding this comment.
will this config be at each plugin level or can it be at the app level as this would be similar for most plugins?
There was a problem hiding this comment.
It is going to be similar for most plugins. I've put it at the plugin level since it was indicated to me that plugins might change code bases in the future. This way it should be self contained and easy to move.
Co-authored-by: Karthik Jeeyar <[email protected]>
|
|
/lgtm |
|
This is awesome @jrichter1 🎉 /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel, karthikjeeyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adds a playwright based test suite for quay plugin. This is to help with automation for features contributed by RHTAP.
Also adds a github action that runs said automation for any plugin that would have it as PR check.