Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(orchestrator): improve workflow instances page table size #1124

Closed
wants to merge 1 commit into from

Conversation

batzionb
Copy link
Contributor

@batzionb batzionb commented Jan 25, 2024

FLPATH-887
Currently the default page size is 5, when often the workflow runs length are more than 5 and there's a lot of space left on the page that is wasted.
To improve this, it will show a table with 20 rows and pagination if there are more than 20 rows, otherwise it'll show a table without pagination.
This behavior matches the backstage catalog tables.
In order to reuse the CatalogPage and avoid duplicating this code, this would be possible when there will be better integration of backstage with the orchestrator and the workflow instances will be backstage entities.

Short list:
image

Long list:
Screencast from 25-01-24 13:53:58.webm

@batzionb batzionb requested a review from a team as a code owner January 25, 2024 11:48
@openshift-ci openshift-ci bot requested review from caponetto and jkilzi January 25, 2024 11:48
@batzionb batzionb force-pushed the FLPATH-888 branch 2 times, most recently from 69c4643 to 35e12cd Compare January 25, 2024 11:53
Copy link
Contributor

@caponetto caponetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @batzionb, please revert the changes outside the orchestrator package.

@jkilzi
Copy link
Member

jkilzi commented Jan 25, 2024

Hey @batzionb, please revert the changes outside the orchestrator package.

I've recreated this PR in #1127. It reverts all the changes outside the Orchestrator.

@jkilzi
Copy link
Member

jkilzi commented Jan 25, 2024

This PR can be closed in favour of #1127

Copy link

openshift-ci bot commented Jan 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from caponetto. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

@batzionb batzionb closed this Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants