fix(rbac): log when plugin has no permissions (#1917)

janus-idp · Aug 2, 2024 · cc8752b · cc8752b
1 parent 3d669d2
commit cc8752b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/plugins/rbac-backend/src/service/plugin-endpoint.test.ts b/plugins/rbac-backend/src/service/plugin-endpoint.test.ts
@@ -124,7 +124,7 @@ describe('plugin-endpoint', () => {
       ]);
     });
 
-    it('should skip not found error for not found endpoint', async () => {
+    it('should log warning for not found endpoint', async () => {
       backendPluginIDsProviderMock.getPluginIds.mockReturnValue([
         'permission',
         'unknown-plugin-id',
@@ -145,6 +145,7 @@ describe('plugin-endpoint', () => {
         '{"permissions":[{"type":"resource","resourceType":"policy-entity","name":"policy.entity.read","attributes":{"action":"read"}}]}',
       );
 
+      const errorSpy = jest.spyOn(logger, 'warn').mockClear();
       const collector = new PluginPermissionMetadataCollector(
         mockPluginEndpointDiscovery,
         backendPluginIDsProviderMock,
@@ -162,6 +163,10 @@ describe('plugin-endpoint', () => {
           policy: 'read',
         },
       ]);
+
+      expect(errorSpy).toHaveBeenCalledWith(
+        'No permission metadata found for unknown-plugin-id. NotFoundError',
+      );
     });
 
     it('should log error when it is not possible to retrieve permission metadata for known endpoint', async () => {

diff --git a/plugins/rbac-backend/src/service/plugin-endpoints.ts b/plugins/rbac-backend/src/service/plugin-endpoints.ts
@@ -142,6 +142,9 @@ export class PluginPermissionMetadataCollector {
       }
     } catch (err) {
       if (isError(err) && err.name === 'NotFoundError') {
+        this.logger.warn(
+          `No permission metadata found for ${pluginId}. ${err}`,
+        );
         return undefined;
       }
       this.logger.error(