feat(rbac): turn rbac plugin into a dynamic plugin (#1133)

* feat(rbac): turn rbac plugin into a dynamic plugin * Removed changes made accidentally Signed-off-by: Yi Cai <[email protected]> * Checkout upstream yarn.lock Signed-off-by: Yi Cai <[email protected]> * Checkout upstream main yarn.lock Signed-off-by: Yi Cai <[email protected]> --------- Signed-off-by: Yi Cai <[email protected]>
janus-idp · Jan 31, 2024 · b9b36d5 · b9b36d5
1 parent 2a42780
commit b9b36d5
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 1 deletion.
diff --git a/plugins/rbac/README.md b/plugins/rbac/README.md
@@ -6,6 +6,13 @@ The RBAC UI plugin offers a streamlined user interface for effectively managing
 
 ### Installation
 
+#### Installing as a dynamic plugin?
+
+The sections below are relevant for static plugins. If the plugin is expected to be installed as a dynamic one:
+
+- follow https://github.com/janus-idp/backstage-showcase/blob/main/showcase-docs/dynamic-plugins.md#installing-a-dynamic-plugin-package-in-the-showcase
+- add content of `app-config.janus-idp.yaml` into `app-config.local.yaml`.
+
 #### Prerequisites
 
 Follow the RBAC backend plugin [README](https://github.com/janus-idp/backstage-plugins/tree/main/plugins/rbac-backend) to integrate rbac in your Backstage instance

diff --git a/plugins/rbac/app-config.janus-idp.yaml b/plugins/rbac/app-config.janus-idp.yaml
@@ -0,0 +1,14 @@
+dynamicPlugins:
+  frontend:
+    janus-idp.backstage-plugin-rbac:
+      appIcons:
+        - name: AdminPanelSettingsOutlinedIcon
+          module: RbacPlugin
+          importName: AdminPanelSettingsOutlinedIcon
+      dynamicRoutes:
+        - path: /rbac
+          importName: RbacPage
+          module: RbacPlugin
+          menuItem:
+            icon: AdminPanelSettingsOutlinedIcon
+            text: Administration
diff --git a/plugins/rbac/package.json b/plugins/rbac/package.json
@@ -62,9 +62,16 @@
     "@types/node": "18.18.5",
     "msw": "1.3.2"
   },
+  "scalprum": {
+    "name": "janus-idp.backstage-plugin-rbac",
+    "exposedModules": {
+      "RbacPlugin": "./src/index.ts"
+    }
+  },
   "files": [
     "dist",
-    "dist-scalprum"
+    "dist-scalprum",
+    "app-config.janus-idp.yaml"
   ],
   "repository": "github:janus-idp/backstage-plugins",
   "keywords": [

diff --git a/plugins/rbac/src/index.ts b/plugins/rbac/src/index.ts
@@ -1 +1,3 @@
 export { rbacPlugin, RbacPage, Administration } from './plugin';
+
+export { default as AdminPanelSettingsOutlinedIcon } from '@mui/icons-material/AdminPanelSettingsOutlined';
Original file line number	Diff line number	Diff line change
		@@ -1 +1,3 @@
		export { rbacPlugin, RbacPage, Administration } from './plugin';

		export { default as AdminPanelSettingsOutlinedIcon } from '@mui/icons-material/AdminPanelSettingsOutlined';