fix(orchestrator): do not show duration when ProcessInstance.end time…

… is n/a (#1112) * chore(orchestrator): renames errorUtils.tsx * fix(orchestrator): do not show duration when ProcessInstance.end time is n/a
janus-idp · Jan 24, 2024 · 75e6bbe · 75e6bbe
1 parent ad11fdf
commit 75e6bbe
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/plugins/orchestrator/src/components/ExecuteWorkflowPage/ExecuteWorkflowPage.tsx b/plugins/orchestrator/src/components/ExecuteWorkflowPage/ExecuteWorkflowPage.tsx
@@ -24,7 +24,7 @@ import {
   executeWorkflowWithBusinessKeyRouteRef,
   workflowInstanceRouteRef,
 } from '../../routes';
-import { getErrorObject } from '../../utils/errorUtils';
+import { getErrorObject } from '../../utils/ErrorUtils';
 import { BaseOrchestratorPage } from '../BaseOrchestratorPage';
 import JsonTextAreaForm from './JsonTextAreaForm';
 import StepperForm from './StepperForm';

diff --git a/plugins/orchestrator/src/components/WorkflowInstancePageContent.tsx b/plugins/orchestrator/src/components/WorkflowInstancePageContent.tsx
@@ -24,11 +24,14 @@ import { WorkflowVariablesViewer } from './WorkflowVariablesViewer';
 export const mapProcessInstanceToDetails = (
   instance: ProcessInstance,
 ): WorkflowRunDetail => {
-  const start = moment(instance.start);
-  const end = moment(instance.end?.toString());
-  const duration = moment.duration(start.diff(end));
-  const name = instance.processName || instance.processId;
   const businessKey = instance.businessKey;
+  const name = instance.processName || instance.processId;
+  const start = moment(instance.start);
+  let duration: string = VALUE_UNAVAILABLE;
+  if (instance.end) {
+    const end = moment(instance.end);
+    duration = moment.duration(start.diff(end)).humanize();
+  }
 
   let variables: Record<string, unknown> | undefined;
   if (typeof instance?.variables === 'string') {
@@ -46,7 +49,7 @@ export const mapProcessInstanceToDetails = (
     name,
     workflow: name,
     started: start.toDate().toLocaleString(),
-    duration: duration.humanize(),
+    duration,
     category: instance.category,
     status: instance.state,
     description: instance.description,

diff --git a/plugins/orchestrator/src/utils/errorUtils.ts → plugins/orchestrator/src/utils/ErrorUtils.ts b/plugins/orchestrator/src/utils/errorUtils.ts → plugins/orchestrator/src/utils/ErrorUtils.ts