Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating plugin for r10k 1.5.x #34

Closed
wants to merge 1 commit into from
Closed

Conversation

cdenneen
Copy link
Contributor

No description provided.

@jantman
Copy link
Owner

jantman commented Oct 28, 2015

PullReview stats

@jantman
Copy link
Owner

jantman commented Oct 28, 2015

PullReview perfect.
Test Infection Your branch must be test infected. lib/vagrant-r10k/action/base.rb:1
Test Infection Your branch must be test infected. spec/unit/action_deploy_spec.rb:1
Test Infection Your branch must be test infected. spec/unit/action_base_spec.rb:1

@cdenneen
Copy link
Contributor Author

I can't get the 2.0.x branch to pass tests but 1.5.x passed so submitted

@cdenneen
Copy link
Contributor Author

@jantman please review the 1.5.x tests I only updated the logging ones that changed I didn't implement 1.5.x new features into tests

@jantman
Copy link
Owner

jantman commented Oct 28, 2015

@cdenneen thanks so much for this. I'm not going to be able to look at it until this afternoon (UTC-4), but I'll do my best to get to it today.

Given the logging changes, I assume that r10k changed its internal logging from the previous debug/debug2 hack?

Also... I'm not sure if you ran the acceptance tests or not... I'll give them a whirl this afternoon and see how badly things changed...

Thanks SO MUCH for this!!!

@jantman
Copy link
Owner

jantman commented Oct 28, 2015

It appears that a number of the acceptance tests are failing, hopefully just due to changes in output. I'm working through them now.

@jantman
Copy link
Owner

jantman commented Oct 28, 2015

@cdenneen is there a reason you bumped the vagrant gem version from 1.7.4 to 1.8.0.dev? I'm seeing some errors I've never seen before with this gem, apparently relating to IPv6.

jantman added a commit that referenced this pull request Oct 29, 2015
@cdenneen
Copy link
Contributor Author

@jantman no i didn't intentionally do that... i removed the Gemfile.lock and ran bundle install which most likely updated the vagrant gem

jantman added a commit that referenced this pull request Oct 29, 2015
jantman added a commit that referenced this pull request Oct 29, 2015
jantman added a commit that referenced this pull request Oct 29, 2015
@jantman jantman mentioned this pull request Oct 29, 2015
@jantman
Copy link
Owner

jantman commented Oct 29, 2015

@cdenneen thanks so much for this. I've made some fixes in #35 to get all the tests passing. This looks good to me; I'm going to merge it and cut a release shortly.

@jantman jantman closed this Oct 29, 2015
jantman added a commit that referenced this pull request Oct 29, 2015
@jantman jantman mentioned this pull request Oct 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants