-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating plugin for r10k 1.5.x #34
Conversation
perfect. |
I can't get the 2.0.x branch to pass tests but 1.5.x passed so submitted |
@jantman please review the 1.5.x tests I only updated the logging ones that changed I didn't implement 1.5.x new features into tests |
@cdenneen thanks so much for this. I'm not going to be able to look at it until this afternoon (UTC-4), but I'll do my best to get to it today. Given the logging changes, I assume that r10k changed its internal logging from the previous debug/debug2 hack? Also... I'm not sure if you ran the acceptance tests or not... I'll give them a whirl this afternoon and see how badly things changed... Thanks SO MUCH for this!!! |
It appears that a number of the acceptance tests are failing, hopefully just due to changes in output. I'm working through them now. |
@cdenneen is there a reason you bumped the |
@jantman no i didn't intentionally do that... i removed the Gemfile.lock and ran bundle install which most likely updated the vagrant gem |
No description provided.