code analysis

[jantman]

Look into running a linter, Code Climate and maybe https://www.pullreview.com/

[jantman]

CodeClimate is working: https://codeclimate.com/github/jantman/vagrant-r10k/code
it flagged 3 methods for complexity, and they might be in number of lines, but they're pretty simple in logic.

[jantman]

CodeClimate should also now be commenting on PRs and opening issues.

[jantman]

PullReview.com actually found a whole bunch of issues, some of which appear really valid (at least idiomatically/stylisticly, whether or not this project needs them or not). It seems a lot better than codeclimate for this purpose.

See: https://www.pullreview.com/github/jantman/vagrant-r10k/reviews/master

[jantman]

Still to do:

1. fix issues found by pullreview.com, or figure out how to ignore them
2. enable PR commenting - https://www.pullreview.com/settings/repositories/175828/how_to_enable_pullrequest_comment

[jantman]

PR commenting enabled in #25

[jantman]

Sent email to [email protected] to try and figure out why (even with manual syncing at both the Review and account level) PullReview isn't updating with new commits or working for PRs. The webhook is also listed as getting a HTTP 422.

If I don't get a response in a day or two, I'll split this branch into 2, one for the fixes and one for enabling pullreview.com, and let the latter sit until this is sorted out.