Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further enhancements #6

Merged
merged 12 commits into from
Dec 22, 2020
Merged

Further enhancements #6

merged 12 commits into from
Dec 22, 2020

Conversation

DL6ER
Copy link
Contributor

@DL6ER DL6ER commented Dec 22, 2020

Contributor License Agreement

By submitting this work for inclusion in wifi-survey-heatmap, I agree to the following terms:

  • The contribution included in this request (and any subsequent revisions or versions of it)
    is being made under the same license as the wifi-survey-heatmap project (the Affero GPL v3,
    or any subsequent version of that license if adopted by wifi-survey-heatmap).
  • My contribution may perpetually be included in and distributed with wifi-survey-heatmap; submitting
    this pull request grants a perpetual, global, unlimited license for it to be used and distributed
    under the terms of wifi-survey-heatmap's license.
  • I have the legal power and rights to agree to these terms.

This pull requests add the following convenience features.

  • Draw a red point if a survey failed. Remove this red point when starting a new survey.
  • Change color of moving point from red to lightblue as we're now using red to indicate failure.
  • Do not start maximized. This makes sense now that we support image scaling.
  • Disable scanning by default as it takes quite some time and does not give all that much information in the end.
  • Make SERVER an optional property to easily skip iperf3 tests in case there is no suitable server.
  • Add frequency graph and differentiate between upload and download UDP jitter.
  • Update Dockerfile to use patched version of libnl
  • Allow starting wifi-survey without any mandatory arguments. Missing items will be asked for with pre-filled interactive dialogs:
    Screenshot from 2020-12-22 11-26-56
    Screenshot from 2020-12-22 11-27-14
    Screenshot from 2020-12-22 11-27-21
  • Store used image filename in JSON file so wifi-heatmaps works with TITLE alone. This can still be overwritten when explicitly specifying an image.
  • Add optional argument --contours N to draw N contours in the image (with inline labels)
    channel_bitrate_Example json
  • Ensure survey points are drawn on top of everything else when they are used and that contour lines are omitted for uniform data.
    channel_Example json
  • Only try to plot for what we have data in the JSON file
  • Allow iperf3 server to be specified as ip:port
  • Update the README to reflect these changes.

DL6ER added 12 commits December 15, 2020 09:49
…there is no suitable server. Also disable scanning by default as it takes quite some time and does not give all that much information in the end. Finally, update the README to reflect these changes

Signed-off-by: DL6ER <[email protected]>
between upload and download UDP jitter.

Signed-off-by: DL6ER <[email protected]>
…tems will be asked for in an interactive manner.

Signed-off-by: DL6ER <[email protected]>
…TLE alone. This can still be overwritten when explicitly specifying an image.

Signed-off-by: DL6ER <[email protected]>
…e used and that contour lines are omitted for uniform data.

Signed-off-by: DL6ER <[email protected]>
@jantman
Copy link
Owner

jantman commented Dec 22, 2020

As usual, thank you so so so much for this!

@jantman jantman merged commit 8dbf419 into jantman:master Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants