Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup of #64 - region and STS support #78

Merged
merged 34 commits into from
Oct 2, 2015
Merged

Fixup of #64 - region and STS support #78

merged 34 commits into from
Oct 2, 2015

Conversation

jantman
Copy link
Owner

@jantman jantman commented Oct 2, 2015

This is a slightly reworked and fixed-up version of #64

philchristensen and others added 30 commits September 29, 2015 21:06
@philchristensen @jantman
Enable cross-account lookup of service limits
1eaaac7
@philchristensen @jantman
docstring update
4946b71
@philchristensen @jantman
some unit test and lint fixes
ddbdcd8
@philchristensen @jantman
more lint fixes
a60d2c6
@philchristensen @jantman
more lint checks to make landscape happy
b87b504
@philchristensen @jantman
modification to avoid passing modules around
d1c1902
@philchristensen @jantman
Trying to make Sphinx happy for the function type
81321ce
@jantman
Fixed cross-account support for TA checks
4496cc4
@jantman
PR #64 - add unit tests for STS in checker and runner
489e511
@jantman
PR #64 - STS service connection unit tests and logging
e508e76
@jantman
PR #64 - STS unit test updates for TrustedAdvisor
f818a28
@jantman
PR #64 finish unit test coverage for new STS-enabled connections
46ca14f
@jantman
PR #64 clean up superfluous imports
7aa3cbb
@jantman
temporarily disable py26 testenv in Travis; failing due to upstream bug
a2e684a 
pytest-dev/pytest#1035
@jantman
changelog for last commit
797ab91
@jantman
PR #64 - ignore :py:obj:function from sphinx warnings, it's not corre…
108781a 
…ctly documented upstream
@jantman
PR #64 fix docstring type
51b10a6
@jantman
PR #64 - PEP8 fixes
68dcc96
@jantman
PR #64 - fix logic error - calling function on function
e342771
@jantman
Revert "PR #64 clean up superfluous imports"
27dfc3e 
This reverts commit 7aa3cbb.
@jantman
some minor fixes in tox.ini
32e79b0
@jantman
PR #64 - regenerate CLI usage docs
5df0474
@jantman
PR #64 - add support for external_id when using STS
39b7643
@jantman
remove superfluous comment
9a603a8
@jantman
PR #64 - major refactor of copy/paste connect() methods out of servic…
47a0602 
…e classes
@jantman
working on docs for PR #64
ab32aa4
@jantman
Revert "PR #64 - major refactor of copy/paste connect() methods out o…
be65975 
…f service classes"

This reverts commit 47a0602.

This refactor didn't work out. When we set
self.connect_function = boto.something.some_function
it becomes a bound method of ``self``, apparently. The end result
is that ``self`` ALWAYS gets passed in as the first argument, and there's
really no way around this. The only alternative would be to set connect_function
to a string, the name of the function to call, but then testing becomes
horrible and it also won't support functions *or* classes.
@jantman
update development docs for PR #64
85616dc
@jantman
PR #64 - refactor connection logic out to a Connectable mixin so Trus…
df4f2f4 
…tedAdvisor doesn't have to be a subclass of _AwsService
@jantman
pep8/flakes fixes
ce79376
@jantman jantman mentioned this pull request Oct 2, 2015
Merged
@codecov-io
Copy link

Current coverage is 100.00%

Merging #78 into develop will not affect coverage as of b415e9e

@@            develop     #78   diff @@
=======================================
  Files            16      17     +1
  Stmts          1170    1229    +59
  Branches        175     184     +9
  Methods           0       0       
=======================================
+ Hit            1170    1229    +59
  Partial           0       0       
  Missed            0       0

Review entire Coverage Diff as of b415e9e

Powered by Codecov. Updated on successful CI builds.

jantman added a commit that referenced this pull request Oct 2, 2015
@jantman
Merge pull request #78 from jantman/pr64
6da2944 
Fixup of #64 - region and STS support
@jantman jantman merged commit 6da2944 into develop Oct 2, 2015
@jantman jantman deleted the pr64 branch October 2, 2015 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jantman @codecov-io @philchristensen