-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use retry mode: standard #537
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #537 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 42 42
Lines 3026 3030 +4
Branches 455 455
=========================================
+ Hits 3026 3030 +4
Continue to review full report at Codecov.
|
@robpickerill I'm going to hold off on merging this one for now. I have some questions about the changes, but more importantly, I've also become a fan of the "adaptive" retry mode, and think that one might be a better option... Also, a nitpick: I'm not in favor of bumping up the max line length. PEP8 clearly says to limit it to 79 characters. I... either find that too antiquated or don't like odd numbers, take your pick... but I don't really want to bump it up by an arbitrary 5 characters for one PR. To be fair (and pedantic?) I also use an editor that's set up to show two 80-character files side by side. |
Hey, would you prefer adaptive? I can change that over if so Your right on the line length, actually not sure why that's in there now I look at it - I can revisit it if you want adaptive |
Yeah, if you don't mind, I think I'd prefer adaptive. We've been using it for some internal projects at work on very busy accounts, and it seems to work quite well. |
This has been released in 12.0.0, which is now live on PyPI and Docker Hub. Thank you so much, and apologies for the delay! |
This PR moves the boto config to using retry mode: standard, as the default retry mode is legacy.
https://boto3.amazonaws.com/v1/documentation/api/latest/guide/retries.html
Please let me know your thoughts on this PR.
Before submitting pull requests, please see the
Development documentation
and specifically the Pull Request Guidelines.
IMPORTANT: Please take note of the below checklist, especially the first three items.
Summary
Add a summary of what your PR does here. This could be as simple as "adds support for X service" or "fixes default limit for Y", or a longer explanation for less straightforward changes.
Pull Request Checklist
writing tests for the code, that's fine, just mention that in the summary and either
ask for assistance, or clarify that you'd like someone else to handle the tests. PRs that
include complete test coverage will usually be merged faster.
tox -e docs
connect()
andconnect_resource()
methods, inherited fromawslimitchecker.connectable.Connectable
if you're working on a GitHub issue (i.e. "issue #x - "). Please
refrain from using the "fixes #x" notation unless you are sure that the
the issue is fixed in that commit.
Contributor License Agreement
By submitting this work for inclusion in awslimitchecker, I agree to the following terms:
is being made under the same license as the awslimitchecker project (the Affero GPL v3,
or any subsequent version of that license if adopted by awslimitchecker).
this pull request grants a perpetual, global, unlimited license for it to be used and distributed
under the terms of awslimitchecker's license.