Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #392 - 6.1.3 release #393

Merged
merged 8 commits into from
Feb 26, 2019
Merged

fixes #392 - 6.1.3 release #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f61ff8d
Update DynamoDB and EFS limits #390
bergkampsliew Feb 26, 2019
d1a422e
Merge branch 'develop' into develop
jantman Feb 26, 2019
41bb781
Unit test for Update DynamoDB and EFS limits #390
bergkampsliew Feb 26, 2019
5730ef2
Merge branch 'develop' of github.com:bergkampsliew/awslimitchecker in…
bergkampsliew Feb 26, 2019
813b9bf
Remove trailing whitespace #390
bergkampsliew Feb 26, 2019
77414e6
Merge pull request #391 from bergkampsliew/develop
jantman Feb 26, 2019
7f5f6d2
CHANGELOG and 6.1.3 version bump
jantman Feb 26, 2019
0427dbf
update docs for limits
jantman Feb 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
Changelog
=========

6.1.3 (2019-02-26)
------------------

* `PR #391 <https://github.com/jantman/awslimitchecker/pull/391>`_ / `Issue #390 <https://github.com/jantman/awslimitchecker/issues/390>`_ - Update for some recently-increased DynamoDB and EFS default limits. Thanks to `bergkampsliew <https://github.com/bergkampsliew>`__.

6.1.2 (2019-02-19)
------------------

Expand Down
2 changes: 1 addition & 1 deletion awslimitchecker/services/dynamodb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ def get_limits(self):
limits['Global Secondary Indexes'] = AwsLimit(
'Global Secondary Indexes',
self,
5,
20,
self.warning_threshold,
self.critical_threshold,
limit_type='AWS::DynamoDB::Table',
Expand Down
2 changes: 1 addition & 1 deletion awslimitchecker/services/efs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ def get_limits(self):
limits['File systems'] = AwsLimit(
'File systems',
self,
125,
1000,
self.warning_threshold,
self.critical_threshold,
limit_type='AWS::EFS::FileSystem',
Expand Down
4 changes: 2 additions & 2 deletions awslimitchecker/tests/services/test_dynamodb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def se_conn(cls):
assert read_capacity_table.limit_type == 'AWS::DynamoDB::Table'
global_secondary_index = limits['Global Secondary Indexes']
assert global_secondary_index.limit_type == 'AWS::DynamoDB::Table'
assert global_secondary_index.default_limit == 5
assert global_secondary_index.default_limit == 20
local_secondary_index = limits['Local Secondary Indexes']
assert local_secondary_index.limit_type == 'AWS::DynamoDB::Table'
assert local_secondary_index.default_limit == 5
Expand Down Expand Up @@ -144,7 +144,7 @@ def se_conn(cls):
assert read_capacity_table.limit_type == 'AWS::DynamoDB::Table'
global_secondary_index = limits['Global Secondary Indexes']
assert global_secondary_index.limit_type == 'AWS::DynamoDB::Table'
assert global_secondary_index.default_limit == 5
assert global_secondary_index.default_limit == 20
local_secondary_index = limits['Local Secondary Indexes']
assert local_secondary_index.limit_type == 'AWS::DynamoDB::Table'
assert local_secondary_index.default_limit == 5
Expand Down
8 changes: 4 additions & 4 deletions awslimitchecker/tests/services/test_efs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def test_get_limits(self):
assert res['File systems'].service == cls
assert res['File systems'].def_warning_threshold == 21
assert res['File systems'].def_critical_threshold == 43
assert res['File systems'].default_limit == 125
assert res['File systems'].default_limit == 1000

def test_update_limits_from_api(self):
mock_conn = Mock()
Expand All @@ -93,7 +93,7 @@ def test_update_limits_from_api(self):
'File systems': AwsLimit(
'File systems',
cls,
125,
1000,
cls.warning_threshold,
cls.critical_threshold,
limit_type='AWS::EFS::FileSystem',
Expand All @@ -102,7 +102,7 @@ def test_update_limits_from_api(self):
cls._update_limits_from_api()
assert mock_connect.mock_calls == [call()]
assert mock_conn.mock_calls == []
assert cls.limits['File systems'].default_limit == 125
assert cls.limits['File systems'].default_limit == 1000

def test_update_limits_from_api_us_east_1(self):
mock_conn = Mock()
Expand All @@ -116,7 +116,7 @@ def test_update_limits_from_api_us_east_1(self):
'File systems': AwsLimit(
'File systems',
cls,
125,
1000,
cls.warning_threshold,
cls.critical_threshold,
limit_type='AWS::EFS::FileSystem',
Expand Down
2 changes: 1 addition & 1 deletion awslimitchecker/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
except ImportError:
logger.error("Unable to import versionfinder", exc_info=True)

_VERSION_TUP = (6, 1, 2)
_VERSION_TUP = (6, 1, 3)
_VERSION = '.'.join([str(x) for x in _VERSION_TUP])
_PROJECT_URL = 'https://github.com/jantman/awslimitchecker'

Expand Down
Loading